Open
Conversation
Mic92
reviewed
Sep 9, 2025
|
|
||
| __dumpEnv() { | ||
| printf '{\n' | ||
| printf ' "version": 1,\n' |
Member
There was a problem hiding this comment.
Not opposing to have this, but have you have a more concrete motivation for this change i.e. can you elaborate how "could even be pushed to binary caches" would be used? Afaik mkShell is buildable and can be already pushed to a binary cache. You removed the the version 1 from flakes again for the reason that a "v2" would be the first explicit version and before everything is "v1".
Member
There was a problem hiding this comment.
I do think some docs would be good. For example, the JSON schema I've been doing would be good for this. I think it is OK if we ret-con version 1 to either have no version, or have version = 1, however. And then version 2 can wait for a more "meaningful" breaking change.
Ericson2314
force-pushed
the
nix-develop-cleanups
branch
3 times, most recently
from
22e2c08 to
9fc7e35
Compare
Member
Ericson2314
force-pushed
the
nix-develop-cleanups
branch
from
9fc7e35 to
82aa3ca
Compare
Ericson2314
changed the title
nix develop: Version the JSON + some cleanupsnix develop: Version the JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds a
version: 1field to the JSON environment file created bynix develop. Since these are not just internal (they are exposed bynix develop --profileandnix develop <storepath>) and could even be pushed to binary caches etc, it's good to future-proof them.Also some miscellaneous cleanups like using
Store::getFSAccessor().Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.